Foundation: clear up some unused return value warnings #366
+132
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just cleans up a set of unused-return-value warnings in the Foundation implementation. NFC.
compnerd
force-pushed
the
unused-return-value
branch
from
2de8d4f to
0d6d0de
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Some of these are actually hiding potential errors or error handling. I am actually very surprised that the glibc functions are being imported with a warning (since they are not annotated with |
|
I agree that error checking would be good (e.g. on stat). However, this is maintaining the status quo. I think that we should figure out which of these are interesting cases to error check and then do that in a follow up change. |
russbishop
pushed a commit
to russbishop/swift-corelibs-foundation
that referenced
this pull request
May 31, 2016
This just cleans up a set of unused-return-value warnings in the Foundation implementation. NFC.
phausler
pushed a commit
that referenced
this pull request
Jun 13, 2016
This just cleans up a set of unused-return-value warnings in the Foundation implementation. NFC.
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just cleans up a set of unused-return-value warnings in the Foundation
implementation. NFC.