-
Notifications
You must be signed in to change notification settings - Fork 1.2k
JSON serializer and tests. #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this going to fail for e.g.
[String]
or[String:Any]
? Because those are not automatically bridged toNSArray
andNSDictionary
on Linux, so unless things have changed, I don't think this will work on Linux.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this is a consequence of the current bridging situation. There is also the fact that the documentation of
NSJSONSerialization
says that the top-level objects must beNSArray
orNSDictionary
- so perhaps the documentation needs updating as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the signature is for
AnyObject
notAny
as well...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, but the parsing code uses native Swift types like
[Any]
and[String: Any]
, which I think is the right way to do it. I think here you should detect native Swift containers as well, so that it works properly both on OS X and Linux.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'NSDictionary' or 'NSArray' language is just a reflection of the JSON spec, which says that the top level must be an 'Object' or 'Array'. We can use a Swift dictionary or array here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parkera That's how I read it too. Now, if @ianpartridge does want to detect the native Swift containers as well, what would you recommend is the right approach? I wrote my own JSON parser Jay, where I had to opt in for ugly (almost) exhaustive checking of all Array/Dictionary types, because of the lack of automatic bridging on Linux. Is there a better way to do it that I missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a recursive descent of the input and checking all types along the way is the most reasonable way to do this for now. There's a lot of libraries out there that are exploring different avenues for parsing JSON in a type-safe way, but I haven't seen a clear winner among the approaches yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that makes sense to tell a
String
from aInt
, but iterating through all possible[String: String]
,[String: Int]
, [String: Double`, ... is less than ideal I think. I'm fine with using this for detecting different JSON-compatible types, but is it really the best way to detect different Array and Dictionary types?