-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Porting to Swift 3 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting to Swift 3 #281
Conversation
@phausler, I've just merged changes to Swift, so this one is good to go. |
Merging the PR to bring CI back to green. |
It is indeed the same thing. #271 was merged and then reverted.
|
Thanks, Dmitri! This one depends in the XCTest, so if you could merge that one as well...
|
Here is the xctest pr: swiftlang/swift-corelibs-xctest#60
|
@moiseev -- ah, thanks for the clarification! 😄 |
Maybe it has been mentioned somewhere, but is there any instruction on running Foundation now with all these Swift 3 changes. I'm struggling to get things going on OSX or Linux. |
@tfrank64 you should not have to change anything. On Linux I used |
@moiseev I'm uncertain what kind of issue I have now. I can run |
@tfrank64 hm.. Since PR is not a very good place for such discussion, I would suggest posting detailed description of your problem to swift-dev mailing list, perhaps somebody has the solution already. At the very least it will be brought to attention of a much wider audience. Feel free to CC me. |
…g#281) While fallback arguments are being used (either from the fallback build system or fallback settings from the primary build system), withhold semantic diagnostics from sourcekitd and all diagnostics from clangd. This helps prevent user confusion from spurious errors. - Also remove the DocumentURI standardization in favor of proper equality + hash checks to work around the %40 --> @ encoding issue seen on CI.
No description provided.