Initial NSDateFormatter tests #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Thanks, always great to have more tests in place. |
|
Glad to help! |
|
lgtm |
|
wonder if this would prove to be useful for the person who made http://nsdateformatter.com |
|
Good question, I saw that yesterday and thought it would be helpful for me. |
bubski
reviewed
Jun 27, 2017
| func test_dateStyleFull() { | ||
|
|
||
| let timestamps = [ | ||
| -31536000 : "Wednesday, January 1, 1969 at 12:00:00 AM GMT" , 0.0 : "Thursday, January 1, 1970 at 12:00:00 AM GMT", |
There was a problem hiding this comment.
Shouldn't the correct value be Greenwich Mean Time instead of GMT?
That's what ICU spec says (http://userguide.icu-project.org/formatparse/datetime)
Also, that's the behaviour of f.timeStyle = .full on macOS.
It appears that for negative timestampts (e.g. -31536000) DateFormatter on macOS wrongly returns GMT instead of Greenwich Mean Time, which seems to be a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily contains tests, but I also added CF attribute setters. I tried to use a wide variety of dates, but more could be added in the future.
More
NSDateFormatterwork coming in future pull requests.