[CF] Match some declarations with their headers. #2598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that standardization on CF types versus C99 types was made, but some changes were missing. As I understand it, on platforms where Boolean (a.k.a. unsigned char, when !DEPLOYMENT_RUNTIME_SWIFT) is convertible to bool, this doesn't cause a problem, but on OpenBSD, bool (a.k.a., _Bool) is an enum, so causes an error. That being said, it certainly appears intended that these should be written as Boolean.
compnerd
approved these changes
Jan 8, 2020
|
@swift-ci please test |
3405691582
added a commit
to 3405691582/swift-corelibs-foundation
that referenced
this pull request
May 11, 2020
In swiftlang#2598, we brought the prototypes and declarations into alignment for _CFPropertyListCreateFiltered and _CFPropertyListCreateSingleValue, namely, using a `Boolean` for prototype and declaration, since they were not matched. It appears with the Catalina merge they were brought into alignment the other way around, namely using `bool` instead. Since the Catalina merge chose `bool`, let's just go with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that standardization on CF types versus C99 types was made,
but some changes were missing. As I understand it, on platforms where
Boolean (a.k.a. unsigned char, when !DEPLOYMENT_RUNTIME_SWIFT) is
convertible to bool, this doesn't cause a problem, but on OpenBSD,
bool (a.k.a., _Bool) is an enum, so causes an error.
That being said, it certainly appears intended that these should be
written as Boolean.