build: cleanup some of the link rules #2596
Merged
+14
−277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the options were in place due to the legacy build. Linking against the imported libraries will both link and include the paths. Furthermore, now with proper Swift support, it is possible to have the library linking be computed transitively. Avoid the double dependency checking. Although libdispatch is also used by Foundation, allow the autolinking to take care of that for the Foundation library as we do not explicitly link against dispatch anywhere.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the options were in place due to the legacy build. Linking
against the imported libraries will both link and include the paths.
Furthermore, now with proper Swift support, it is possible to have the
library linking be computed transitively. Avoid the double dependency
checking. Although libdispatch is also used by Foundation, allow the
autolinking to take care of that for the Foundation library as we do not
explicitly link against dispatch anywhere.