don't rely on getdtablesize() #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
spevans
reviewed
Dec 12, 2019
|
@swift-ci please test |
|
@swift-ci please test |
Android and possibly other UNIX systems lack getdtablesize() so let's try to use a better way of estimating the file descriptors we need to close post-fork, pre-exec by listing /proc/self/fd. If that fails, we fall back on getdtablesize or as a last resort a hard-coded 4096.
|
@swift-ci please test |
spevans
reviewed
Dec 12, 2019
| } | ||
|
|
||
| return highestFDSoFar | ||
| } |
There was a problem hiding this comment.
Would
return try? FileManager.default.contentsOfDirectory(atPath: "/proc/self/fd").compactMap { CInt($0) }.max()
be a bit simpler?
There was a problem hiding this comment.
@spevans I wasn't sure about the guarantees around symlinks as in does it follow symlinks, does it not, what happens if the symlink is a broken link, etc. Therefore I went for readdir, happy to change if we think it's fine.
This was referenced Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android and possibly other UNIX systems lack getdtablesize() so let's
try to use a better way of estimating the file descriptors we need to
close post-fork, pre-exec by listing /proc/self/fd. If that fails, we
fall back on getdtablesize or as a last resort a hard-coded 4096.