[Windows] Remove Fallback Path with Loading Bundles #2540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading an invalid bundle rather than failing as the Darwin path does, it instead returns the parent directory of the given bundle as an unloaded bundle. This removes the hunk so that the Windows behavior matches the other platforms.
|
cc @millenomi @compnerd @parkera I don't have context about what this bit was actually added for, it's part of the original implementation commit with no other explanation about why it's needed. Does anyone know what might break if it is removed? |
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading an invalid bundle rather than failing as the Darwin path
does, it instead returns the parent directory of the given bundle as an
unloaded bundle.
This removes the hunk so that the Windows behavior matches the other
platforms.