Skip to content

Revert "Process: do not inherit all file descriptors to child processes" #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

shahmishal
Copy link
Member

Reverts #2485

We are seeing failure on Ubuntu 18.04:

https://ci.swift.org/job/oss-swift-package-linux-ubuntu-18_04/2002/console

21:15:52 Test Case 'TestProcess.test_fileDescriptorsAreNotInherited' started at 2019-10-15 04:15:28.804
21:15:52 
/home/buildnode/jenkins/workspace/oss-swift-package-linux-ubuntu-18_04/swift-corelibs-foundation/TestFoundation/TestProcess.swift:587: error: TestProcess.test_fileDescriptorsAreNotInherited : XCTAssertTrue failed - 
21:15:52 /home/buildnode/jenkins/workspace/oss-swift-package-linux-ubuntu-18_04/swift-corelibs-foundation/TestFoundation/TestProcess.swift:588: error: TestProcess.test_fileDescriptorsAreNotInherited : XCTAssertEqual failed: ("5") is not equal to ("6") - 0
21:15:52 1
21:15:52 2
21:15:52 94
21:15:52 
21:15:52 Test Case 'TestProcess.test_fileDescriptorsAreNotInherited' failed (3.39 seconds)

cc: @weissi

@shahmishal shahmishal merged commit 3592d8a into master Oct 16, 2019
@shahmishal shahmishal deleted the revert-2485-jw-dont-inherit-fds branch October 16, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant