Process: .currentDirectoryURL and .executableURL fixes #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
spevans
force-pushed
the
pr_process_current_directory
branch
from
442a0ab to
49f825e
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
- currentDirectoryURL should be of type URL? - Disallow setting either property to nil or a non-File URL, to match Darwin. - Dont set PWD environment variable, it should just be copied from the current environment, to match Darwin.
spevans
force-pushed
the
pr_process_current_directory
branch
from
49f825e to
2427fb2
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
compnerd
reviewed
Sep 30, 2019
| get { _executable } | ||
| set { | ||
| guard let url = newValue, url.isFileURL else { | ||
| fatalError("must provide a launch path") |
There was a problem hiding this comment.
Is fatalError correct? Should this not be an exception of sorts?
There was a problem hiding this comment.
Darwin throws NSException so fatalError is the swift equivalent. Also it is a property so nothing else that could be done anyway.
| get { _currentDirectoryURL } | ||
| set { | ||
| guard let url = newValue, url.isFileURL else { | ||
| fatalError("non-file URL argument") |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
|
I think that this breaks the Windows build: https://dev.azure.com/compnerd/3133d6ab-80a8-4996-ac4f-03df25cd3224/_apis/build/builds/12302/logs/95 |
|
@compnerd That's annoying, I will sort out a fix. I just realised I need to add an extra test for when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentDirectoryURL should be of type URL?
Disallow setting either property to nil or a non-File URL,
to match Darwin.
Dont set PWD environment variable, it should just be copied from the
current environment, to match Darwin.