[CoreFoundation] Use a Windows Timezone if we are given one #2512
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmittert
force-pushed
the
IsItTimeYet
branch
from
b3f426f to
d982301
Compare
|
@swift-ci please test |
Before attempting to check if a timezone is an abbreviation or Olson format, we should make sure we can't just query Windows for the timezone. For example, CFTimeZoneCopyKnownNames will return UTC[-+XX] timezones which we would otherwise would fail on.
gmittert
force-pushed
the
IsItTimeYet
branch
from
d982301 to
dadf095
Compare
compnerd
approved these changes
Sep 17, 2019
|
Please synchronise with @millenomi on merging this |
|
@swift-ci please test |
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before attempting to check if a timezone is an abbreviation or Olson
format, we should make sure we can't just query Windows for the
timezone. For example, CFTimeZoneCopyKnownNames will return UTC[-+XX]
timezones which should otherwise would fail on.