[Windows] Fix TestURL/test_URLStrings #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@millenomi Are you okay with doing testing like this? Is there a better way to do it? |
|
@swift-ci please test linux |
gmittert
force-pushed
the
StillLegalInSanFrancisco
branch
from
abb574c to
fefa12a
Compare
Since '|' is a valid character in a url on Windows as implemented by CoreFoundation, on Windows, we should expect that `unescaped|pipe` should be properly parsed. This is hacky, but adds a test case on Windows, and disables it on other platforms and vice versa.
gmittert
force-pushed
the
StillLegalInSanFrancisco
branch
from
fefa12a to
5ef5dc3
Compare
|
@swift-ci please test linux |
|
Thank you for cleaning up the logic here! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since '|' is a valid character in a url on Windows as implemented by
CoreFoundation, on Windows, we should expect that
unescaped|pipeshould be properly parsed.
This is hacky, but adds a test case on Windows, and disables it on other
platforms and vice versa.