Fixed a crash that happens when you attempt to get the name of an XML document

[ghost]

Name now returns nil instead of crashing. This was done by adding Document to the types of XML to ignore, returning early like the other XML types ineligible for a name are. 5.1 is not out yet, so I put this is 5.0.

[ghost]

Did!

[xwu]

There are still unrelated changes. I assume you meant to open a PR against the master branch?

[millenomi]

@pi1024e: I appreciate that these issues are real, but there are a few problems with your approaches:

• One issue per patch, please. The CFString changes are unrelated, can you remove them?
• We do not take 5.0 (monthly release) patches that aren't being backported or cherry-picked from master. Can you retarget this to master?

[millenomi]

Per above.

[YOCKOW]

@xwu @millenomi

I feel it's a little confusing direction.

• If this PR is retargeted to master, it will be the same with Fix crash that occurs when attempting to retrieve the name property of an XMLDocument by making it return nil. #2453.
• The approach of Fix crash that occurs when attempting to retrieve the name property of an XMLDocument by making it return nil. #2453 (that still contains unrelated changes and incorrect modification though) is now the same with SR-10776: Fix runtime crash of calling XMLDocument's var name: String? #2316.
• SR-10776: Fix runtime crash of calling XMLDocument's var name: String? #2316 is open still.
• That is, there are/will be three PRs to fix the same issue SR-10776.

---

@pi1024e

One of the important things that I said is

Why don’t you review #2316 before creating a new PR?

I think @xwu also said the same thing:

if you're interested in helping to resolve such an issue or disagree with how they've approached the topic, you can review their work and offer to help that person.

[millenomi]

I'm calling an audible and consolidating the effort into #2316.