Split: FoundationXML #2432
Split: FoundationXML #2432
Conversation
Split the portions of Foundation that depend on libxml2 into their own module, FoundationXML. This is the last module to be split off.
|
@swift-ci please test |
|
Probably worth adding an integration test along the lines of https://github.com/apple/swift-integration-tests/pull/60/files to check it all builds ok |
|
Agreed. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
The failure is unrelated; let's see how Linux fares. |
|
The failure will be fixed by swiftlang/swift#26372 |
|
@swift-ci please test |
…nostics as we did for …Networking.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
swiftpm needs an adoption patch; I’ll whip one up tomorrow. cc @aciidb0mb3r |
|
Oh wow. I just landed that today, sorry! ._. |
|
@millenomi This should do it: swiftlang/swift-package-manager#2257 |
|
Please test with following pull request: @swift-ci Please test Linux |
|
Please test with the following: @swift-ci please test Linux |
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
|
Yeah, the adoption patch needs to go the whole nine yards the same way we did with FoundationNetworking. I’ll do it today. |
Ensure all constituent modules of Foundation are available, including their (for now, visible) implementation dependencies. Must land in lockstep with swiftlang/swift-corelibs-foundation#2432
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
1 similar comment
|
Please test with the following: @swift-ci please test |
|
It's green on the SPM patch, but let's wait until these are finished and the smoke tests finish there. |
|
The failure is in llbuild and is unrelated. @aciidb0mb3r |
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
1 similar comment
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
| ${WORKAROUND_SR9995} | ||
| SWIFT_FLAGS | ||
| -DDEPLOYMENT_RUNTIME_SWIFT | ||
| -DNS_BUILDING_FOUNDATION_NETWORKING |
There was a problem hiding this comment.
Is this one correct? Or necessary? I don't see it used anywhere else in the commit (unless it appears in some unexpanded file). If we rely on it because it was already used like this in FoundationNetworking, maybe it would be good to update it to something more “neutral”. If anyone knows the answer, I will not mind doing the PR, but I don’t exactly know what to do.
There was a problem hiding this comment.
That was, indeed, a mistake.
There is one file that is shared between the Foundation and FoundationNetworking builds containing internal calls; in Networking, we have to import Foundation, and that's what this guards. It is unnecessary in FoundationXML.
Ensure all constituent modules of Foundation are available, including their (for now, visible) implementation dependencies. Must land in lockstep with swiftlang/swift-corelibs-foundation#2432
func parserDidEndDocument(_ parser: XMLParser)not getting called |
Split the portions of Foundation that depend on libxml2 into their own module,
FoundationXML. This is the last module to be split off.