Skip to content

[Windows] Mark Symlinked Directories as Symlinks #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

gmittert
Copy link
Contributor

On Windows, symlinks to directories are both symlinks and directories.
To emulate posix, we should treat them as only symlinks and not
directories.

@gmittert gmittert requested a review from compnerd July 12, 2019 21:28
@gmittert
Copy link
Contributor Author

@swift-ci please test linux

On Windows, symlinks to directories are both symlinks and directories.
To emulate posix, we should treat them as only symlinks and not
directories.
@gmittert gmittert force-pushed the YouOnlyGetToChooseOne branch from 8d7bb38 to be67538 Compare July 15, 2019 17:51
@gmittert
Copy link
Contributor Author

  • Removed extra name comments
  • fileHandle -> handle
  • Added a guard on the handle

@gmittert
Copy link
Contributor Author

@swift-ci please test linux

@gmittert
Copy link
Contributor Author

@swift-ci please test linux

@gmittert gmittert merged commit 21f5313 into swiftlang:master Jul 16, 2019
@gmittert gmittert deleted the YouOnlyGetToChooseOne branch July 16, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants