Skip to content

Fix TestProcessInfo on Windows #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Fix TestProcessInfo on Windows #2372

merged 1 commit into from
Jul 16, 2019

Conversation

gmittert
Copy link
Contributor

  • The Executable name should have .exe
  • Windows doesn't have setenv, so make putenv work more like it and accept keys with = in them.

@gmittert
Copy link
Contributor Author

@swift-ci please test

compnerd
compnerd reviewed Jun 24, 2019
View reviewed changes
@gmittert
Copy link
Contributor Author

gmittert commented Jul 9, 2019

rebased

@gmittert
Copy link
Contributor Author

@swift-ci please test linux

@gmittert
Fix TestProcessInfo on Windows
63c3229 
- The Executable name should have .exe
- Windows doesn't have setenv, so make putenv work more like it
@gmittert
Copy link
Contributor Author

@swift-ci please test linux

@gmittert gmittert merged commit 06ccad8 into swiftlang:master Jul 16, 2019
@gmittert gmittert deleted the TestProcessInfo branch July 16, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmittert @compnerd