Base: implement KnownLocations for android #2353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci test linux |
drodriguez
requested changes
Jun 16, 2019
|
@swift-ci please test |
drodriguez
approved these changes
Jun 18, 2019
|
My proposal is: Let’s revert to the non-abort patch and mandate that people set |
|
(That way, they can source the internal storage path from an activity without us guessing.) |
|
This can be enforced by |
|
@swift-ci please test |
millenomi
reviewed
Jun 18, 2019
|
I also approve the environment variable approach (with the last comment by Lily implemented). |
Add a path through KnownLocations for android. This currently cannot be computed as we do not have the activity context nor do we know if the activity was spawned from the zygote or was a NDK process so we do not have a reference to Davlik to JNI and query the required information. This is sufficient to get the SDK building for android though.
|
@swift-ci please test |
millenomi
approved these changes
Jun 19, 2019
|
While we’re using it directly here, it is also already picked up by CFPlatform.c, so API like NSHomeDirectory(), FileManager etc. will all heed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for android to KnownLocations. Assume that only current
user is supported as all applications in android are isolated and single
user. For now, place all files in ~/Apple/Library/Preferences. This is
the last piece needed in CoreFoundation for Android support.