-
Notifications
You must be signed in to change notification settings - Fork 1.2k
build: Add scripts to build and test using Xcode #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
@swift-ci test linux |
Why do we need the script again? |
I want to get a swift-ci target setup that allows testing a PR against the Dawin Compatibility Tests. |
Good enough. Do you want to set the toolchain in the script? |
e1d6046
to
64b1f3d
Compare
@millenomi Im not sure how to set the toolchain, ideally the swift-ci would just use the latest one available, I assume it would need to download it and set it as the default in Xcode as part of its setup before invoking the script. |
@swift-ci test |
@spevans We do that for the protobuf builds. E.x.: https://ci.swift.org/view/all/job/swift-protobuf-linux-ubuntu-16_04/1222/consoleFull I would talk with Mishal about the frequency though. I imagine that we probably want to run it only when the toolchain changes. |
And if that, probably at most once a day (if not once a week). |
@gottesmm I opened https://bugs.swift.org/browse/SR-10990 for getting the test setup. For now I just want the ability to run them manually as there will be times when they would fail (eg with a PR dependant on a PR in another repo where its not in a toolchain) , eventually they may get added to the swift-ci test for scl-f alongside linux and macos |
Please test with following PR: |
- xcode-build.sh builds and optionally tests SwiftFoundation. usage: ./xcode-build.sh [--clean] [--debug|--release] [--test] - DarwinCompatibilityTests/xcode-build.sh builds and tests using the DarwinCompatibilityTests. usage: DarwinCompatibilityTests/xcode-build.sh [--clean]
64b1f3d
to
0870e68
Compare
@swift-ci test |
@swift-ci test and merge |
xcode-build.sh builds and optionally tests SwiftFoundation.
usage: ./xcode-build.sh [--clean] [--test]
DarwinCompatibilityTests/xcode-build.sh builds and tests using
the DarwinCompatibilityTests.
usage: DarwinCompatibilityTests/xcode-build.sh [--clean]
This adds two shell scripts for building/testing scl-foundation using Xcode as a check that changes don't break the Xcode builds for
TestFoundation
andDarwinCompatibilityTests
. A recent toolchain snapshot is required. The idea is that both scripts could be hooked up toswift-ci test
commands to enable extra CI testing. If these scripts look OK, I will open a jira to get swift-ci updated.The
DarwinCompatibiltyTests
only includes test classes that currently work without any failing test cases.