Parity: FileManager.replaceItem(…) #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
I need a wrapper for renameat2, I assume. |
- Instead of returning nothing from .url(for: .itemReplacementDirectory…), produce a path the same way Darwin does. - Implement replaceItems(…) for POSIX-y platforms. We try to use Darwin and Linux swap syscalls to ensure race-free atomicity if available, and if these fail we fall back to an implementation that has different degrees of atomicity depending on what object is replaced with what object. - Add tests.
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
@pschuh A |
|
Sounds good! I just need to wait for the update-checkout to get up to that version then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning nothing from .url(for: .itemReplacementDirectory…), produce a path the same way Darwin does.
Implement replaceItems(…) for POSIX-y platforms. We try to use Darwin and Linux swap syscalls to ensure race-free atomicity if available, and if these fail we fall back to an implementation that has different degrees of atomicity depending on what object is replaced with what object.
Add tests.