CoreFoundation: avoid CFString construction in CFURLSessionINterface
#2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
millenomi
reviewed
May 25, 2019
millenomi
reviewed
May 25, 2019
|
@swift-ci please test and merge |
|
@swift-ci please test and merge |
|
@swift-ci please test and merge |
|
@swift-ci please test and merge |
|
@swift-ci please test and merge |
This causes a reference to `CFStringCreateWithBytes` and `kCFDefaultSystemAllocator` in `CFURLSessionInterface` which requires linking against CoreFoundation. Since the swift deployment uses CoreFoundation statically, this would require a second instance of CoreFoundation OR that private CoreFoundation interfaces are re-exposed through Foundation which is explicitly undesired. Perform the String construction in Swift and instead just have a trivial wrapper for `curl_easy_strerror`.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a reference to
CFStringCreateWithBytesandkCFDefaultSystemAllocatorinCFURLSessionInterfacewhich requireslinking against CoreFoundation. Since the swift deployment uses
CoreFoundation statically, this would require a second instance of
CoreFoundation OR that private CoreFoundation interfaces are re-exposed
through Foundation which is explicitly undesired. Perform the String
construction in Swift and instead just have a trivial wrapper for
curl_easy_strerror.