Prevent pipe-based FileHandle tests from hanging #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
beccadax
force-pushed
the
pipe-dreams
branch
2 times, most recently
from
a62ea41 to
26e8399
Compare
|
Lily asked for something that didn't use expectations, so this just does the simplest possible thing: writes the data to a temporary file and reads it back. @swift-ci please test |
Writing to a pipe can block if an internal buffer fills up, and the size of the buffer varies by platform and even kernel version, which may be causing the `TestFileHandle.testWritingWith*()` tests to hang. Address this by using a temporary file instead.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to a pipe can block if an internal buffer fills up, and the size of the buffer varies by platform and even kernel version, which may be causing the
TestFileHandle.testWritingWith*()tests to hang. Address this bywriting from a background queue and imposing a timeout on the writewriting to a temporary file and then reading it back.