Parity: NSPredicate and NSExpression #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
- Add diagnostics for features not supported by swift-corelibs-foundation, including format strings (which rely on key-value coding for most of their usefulness). - NSComparisonPredicate relies on NSExpression, which is not going to be available. Mark it as unavailable. - Predicate archival relies on format strings. Remove the NSSecureCoding conformance of NSPredicate, since we cannot safely assert to be able to encode or decode arbitrary predicates.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
This was referenced May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diagnostics for features not supported by swift-corelibs-foundation, including format strings (which rely on key-value coding for most of their usefulness).
NSComparisonPredicaterelies onNSExpression, which is not going to be available. Mark it as unavailable.Predicate archival relies on format strings. Remove the
NSSecureCodingconformance ofNSPredicate, since we cannot safely assert to be able to encode or decode arbitrary predicates.