Skip to content

[5.0] SR-10619: Order in which DateFormatter settings are set up matters on… #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2019
Merged

Conversation

weissi
Copy link
Contributor

@weissi weissi commented May 14, 2019

… Linux

  • Ensure the setting of .dateStyle and .timeStyle isnt dependant on the
    current setting of .locale.

(cherry picked from commit 3ceecb1)
original PR #2265

@weissi weissi changed the title [5.0] [5.0] SR-10619: Order in which DateFormatter settings are set up matters on… May 14, 2019
@weissi weissi changed the title [5.0] SR-10619: Order in which DateFormatter settings are set up matters on… [AFTER #2264] [5.0] SR-10619: Order in which DateFormatter settings are set up matters on… May 14, 2019
@weissi weissi requested a review from kevints May 14, 2019 10:44
@kevints
Copy link
Contributor

kevints commented May 14, 2019

@swift-ci please test

@kevints
Copy link
Contributor

kevints commented May 14, 2019

@weissi this one needs a rebase

… Linux

- Ensure the setting of .dateStyle and .timeStyle isnt dependant on the
  current setting of .locale.

(cherry picked from commit 3ceecb1)
@weissi
Copy link
Contributor Author

weissi commented May 14, 2019

thanks @kevints, done

@weissi weissi changed the title [AFTER #2264] [5.0] SR-10619: Order in which DateFormatter settings are set up matters on… [5.0] SR-10619: Order in which DateFormatter settings are set up matters on… May 14, 2019
@kevints
Copy link
Contributor

kevints commented May 14, 2019

@swift-ci test and merge

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 225bc35 into swiftlang:swift-5.0-branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants