Skip to content

plutil: Fix RUNPATH and file permissions of installed binary #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2018
Merged

plutil: Fix RUNPATH and file permissions of installed binary #1789

merged 1 commit into from
Dec 1, 2018

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Nov 28, 2018

No description provided.

@spevans spevans requested a review from compnerd November 28, 2018 21:59
@spevans
Copy link
Contributor Author

spevans commented Nov 28, 2018

@swift-ci test

compnerd
compnerd approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@spevans
Copy link
Contributor Author

spevans commented Dec 1, 2018

@swift-ci test and merge

@ianpartridge
Copy link
Contributor

Is this part of fixing https://bugs.swift.org/browse/SR-9347 ?

@spevans
Copy link
Contributor Author

spevans commented Dec 1, 2018

No, plutil was never copied into the installation directory in previous versions of swift, which was fixed by CMake changes, but it needed permissions being set correctly and a valid RUNPATH.

@swift-ci swift-ci merged commit 6b2c8cf into swiftlang:master Dec 1, 2018
@spevans spevans mentioned this pull request May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spevans @ianpartridge @compnerd @swift-ci