repair static builds of Foundation #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @kevints |
Correct the library name specification for the ICU components. We would get away with this as there can be unresolved symbols in a shared link. Link in the implicit dependencies pulled in through Foundation via CoreFoundation. When statically linking, we would no longer link against CoreFoundation.
|
@swift-ci please test |
|
Actually, thinking about this, we can commit this, it won't break anything, but will allow static builds to work. The issue with build-script can be addressed with this committed. |
|
@compnerd Should we be building |
spevans
reviewed
Nov 28, 2018
| @@ -250,7 +248,7 @@ add_swift_library(Foundation | |||
| -L${install_dir}/usr/lib | |||
| -lCoreFoundation | |||
| ${CURL_LIBRARIES} | |||
| ${ICU_UC_LIBRARIES} ${ICU_I18N_LIBRARIES} | |||
| ${ICU_UC_LIBRARY} ${ICU_I18N_LIBRARY} | |||
| ${LIBXML2_LIBRARIES} | |||
There was a problem hiding this comment.
@compnerd This change seems to have broken it and also in the set(Foundation_INTERFACE_LIBRARIES below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.