SR-8078: Some time zone identifiers are not supported by TimeZone on Linux #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Linux - TimeZone.knownTimeZoneIdentifiers was returning time zone names that could not be instantiated by TimeZone(identifier:) due to CFTimeZone.c:__nameStringOK() filtering out some names. - Make CFTimeZoneCopyKnownNames(), used by .knownTimeZoneIdentifiers, also filter these names using __nameStringOK(). - __nameStringOK calls ICU function ucal_getCanonicalTimeZoneID which ultimately decides if the time zone is valid.
|
@swift-ci please test |
|
LGTM |
parkera
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeZone.knownTimeZoneIdentifiers was returning time zone names
that could not be instantiated by TimeZone(identifier:) due to
CFTimeZone.c:__nameStringOK() filtering out some names.
Make CFTimeZoneCopyKnownNames(), used by .knownTimeZoneIdentifiers,
also filter these names using __nameStringOK().
__nameStringOK calls ICU function ucal_getCanonicalTimeZoneID
which ultimately decides if the time zone is valid.
https://bugs.swift.org/browse/SR-8078