Skip to content

[SR-7861] Fix for HTTP redirect failure on Linux #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2018
Merged

[SR-7861] Fix for HTTP redirect failure on Linux #1577

merged 1 commit into from
Jun 6, 2018

Conversation

nethraravindran
Copy link
Contributor

Codepaths in HTTPURLProtocol missed to assign the port for the new redirect request which leads to the failure in redirection.

@ianpartridge
Copy link
Contributor

@swift-ci please test

@ianpartridge ianpartridge merged commit e159524 into swiftlang:master Jun 6, 2018
@ianpartridge
Copy link
Contributor

I've merged this without a test because we need this fix in a toolchain asap. We do have a test for it, and it passes, but it's written on top of #1569 which isn't ready yet. Once #1569 is merged we will add the test for this issue too.

@swift-ci swift-ci mentioned this pull request Jun 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nethraravindran @ianpartridge