https://bugs.swift.org/browse/SR-6812 #1557
Conversation
|
Thanks @chnmrc ! This seems pretty straight-forward to me. |
|
I assume this just moves the CF types to the memory layout Swift objects have on 32 bit platforms? Is it the same on other 32 bit platforms or does it need a specific armv7 guard? |
|
That's a good question. We don't have testing on other non-supported 32-bit platforms. As there aren't any other 32-bit platforms in community CI, I can't be sure who represents those platforms, if they're being used at all. |
| @@ -195,10 +195,18 @@ typedef struct __CFRuntimeBase { | |||
| uintptr_t _cfisa; | |||
| uintptr_t _swift_rc; | |||
| // This is for CF's use, and must match _NSCFType layout | |||
| #if __LP64__ | |||
There was a problem hiding this comment.
Yes, for Windows also, maybe we must add an || condition.
There was a problem hiding this comment.
Looks like the .c file was updated but not the .h file?
There was a problem hiding this comment.
Is that a question to me?
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Resolve a bug that affects ARMv7 system
https://bugs.swift.org/browse/SR-6812