[Need Feedback]: Added bounds checking to NSArray subscript

[KaiCode2]

Completed bounds checking however I need feedback on what should should be done if the index is out of range.

[KaiCode2]

@phausler I corrected the PR to incorporate the changes you mentioned. Let me know if there is anything else to add 🙂

[parkera]

Thanks, this looks good. Could you rebase this into a single commit for us to merge in?

[Adlai-Holler]

Would precondition(idx >= 0 && idx < count) be a cleaner equivalent?

[KaiCode2]

@parkera finished the rebase, let me know if it's all good.

[parkera]

@Adlai-Holler precondition sounds like it might be good too, since it takes the optimization level into account. We can consider that as another change (also perhaps moving this into the objectAtIndex call itself as discussed on mailing list).

[KaiCode2]

@Adlai-Holler I think the issue with the precondition is the lack of an error message on release builds.

[gribozavr]

You can provide a message as the second parameter to precondition(). The message is displayed in debug builds.