NSMutableData: Restore missing initialisers #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When aligning the init() methods with Darwin in PR swiftlang#1287, converting the NSData `convenience` methods to designated initialisers stopped them from being inherited by NSMutableData as it declared its own designed initialisers. - Add in all of the missing initialisers and add tests to ensure their presence is checked at compile time. - Fix init(data: Data) to use the correct length of the data argument when copying the bytes.
|
@swift-ci please test |
phausler
reviewed
Jan 2, 2018
| @@ -206,7 +206,6 @@ class TestNSData: XCTestCase { | |||
| ("test_dataHash", test_dataHash), | |||
| ("test_genericBuffers", test_genericBuffers), | |||
| ("test_writeFailure", test_writeFailure), | |||
| ("testBasicConstruction", testBasicConstruction), | |||
There was a problem hiding this comment.
why was this test removed?
There was a problem hiding this comment.
It was a duplicate line, that test is called on line 198
There was a problem hiding this comment.
ah ok, I see it past the code fold
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When aligning the init() methods with Darwin in PR NSData: Align methods with Darwin #1287,
converting the NSData
conveniencemethods to designatedinitialisers stopped them from being inherited by NSMutableData
as it declared its own designed initialisers.
Add in all of the missing initialisers and add tests to ensure
their presence is checked at compile time.
Fix init(data: Data) to use the correct length of the data
argument when copying the bytes.