Import CoreFoundation sources from High Sierra

[phausler]

This is the latest changes from CoreFoundation, round tripped to include the latest additions in High Sierra. Careful review should be taken for non x86_64 linux platforms since we have not yet tested other targets. Some header paths were simplified to use __has_include instead of relying on DEPLOYMENT_RUNTIME_SWIFT macros. Other areas were unfortunately reverted back to the Darwin implementation since the open source versions caused problems when integrating back into the Darwin version.

Major areas of consideration include the way retain counts are handled and CF type bit fields work.

The Xcode project now removes the index store disable flag which should vastly improve build times (since that option is no longer needed)

[phausler]

@swift-ci please test

[jpsim]

@phausler does this fix SR-3158? Looks like it might from this:

-#define FORMAT_STRING_MAX_LENGTH 29     // Length of "yyyy-'W'ww-dd'T'HH:mm:ssXXXXX"
+#define FORMAT_STRING_MAX_LENGTH 33     // Length of "yyyy-'W'ww-dd'T'HH:mm:ss.SSSXXXXX"
...
+        // Add support for fracional seconds
+        if (includeFractionalSecs) {
+            CFStringAppendCString(resultStr, ".SSS", kCFStringEncodingUTF8);
+        }

Nitpick: there's a typo in that comment s/fracional/fractional/

[parkera]

That was part of our support for fractional seconds in ISO8601. In the ObjC header (NSISO8601DateFormatter.h):

    NSISO8601DateFormatWithFractionalSeconds API_AVAILABLE(macosx(10.13), ios(11.0), watchos(4.0), tvos(11.0)) = kCFISO8601DateFormatWithFractionalSeconds,  // Add 3 significant digits of fractional seconds (".SSS")

[phausler]

@swift-ci please test

[alblue]

@phausler looks like there are conflicts - can you rebase onto master and try again?

[ianpartridge]

Other areas were unfortunately reverted back to the Darwin implementation since the open source versions caused problems when integrating back into the Darwin version.

@phausler did you note where those are? I wouldn't want us to lose things by accident...

[phausler]

The specific case that was reverted was in two spots: 1) the CFLog constants and 2) CFInternal.h definition for CF_EXPORT

[phausler]

@swift-ci please test

[alblue]

@swift-ci please test

[parkera]

@phausler ready to merge this?

[phausler]

Yep seems good to go by me

[alblue]

@swift-ci please test and merge

[slavapestov]

This broke the build on Ubuntu 14.04 because UMS_UK is not defined. Can we revert this for now?

[phausler]

I’d prefer not to and to instead ifdef out the usage

[alblue]

It looks like @slavapestov reverted the commit in

60b7bd2

So this will need to be re-reverted again at some point.