Codable conformance for URLComponents #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The lack of an un-deallocatable nature of CFSTR is a known issue that stems from us deciding to use Swift objects to underlie all CF types. Using the CFStringCreateCopy is a good enough workaround for now. |
parkera
approved these changes
Nov 6, 2017
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1108, #1127, #1148 & #1192
This PR mirrors final missing changes from swiftlang/swift#11368
Added conformances + unit tests for
I had problems with
NSCFConstantStringbeing overreleased (CFStringconstants bridged from CoreFoundation'sCFSTR("")).I don't know how to properly fix this, so any advice is welcome.
I took the inspiration for a
CFStringCreateCopyworkaround from https://github.com/apple/swift-corelibs-foundation/pull/144/files