NSLocalizedString stub #1263
Merged
NSLocalizedString stub #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, same implementation as in https://github.com/apple/swift/blob/485ebefba7ae044c85bcbd4ebf48bfd18c807c2f/stdlib/public/SDK/Foundation/Foundation.swift#L34-L40 @swift-ci please test and merge |
| @@ -20,6 +20,16 @@ extension unichar : ExpressibleByUnicodeScalarLiteral { | |||
| } | |||
| } | |||
|
|
|||
| // Placeholder for a future implementation | |||
There was a problem hiding this comment.
Is this comment correct? Haven't you provided the implementation?
There was a problem hiding this comment.
I’ll remove it from the rebase.
There was a problem hiding this comment.
The comment from the SDK implementation reads:
/// Returns a localized string, using the main bundle if one is not specified.
Maybe we can use that instead?
There was a problem hiding this comment.
Sure, added to the rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For separate review