Added build-android script #1241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @amraboelela, see if you can salvage a few tips from https://github.com/apple/swift-corelibs-foundation/pull/1113/files which has some different takes on thread names, NI_MAXHOST etc. |
spevans
reviewed
Oct 3, 2017
| @@ -20,3 +20,5 @@ Build | |||
| *.swp | |||
| *.orig | |||
| .arcconfig | |||
|
|
|||
| build.ninjae | |||
There was a problem hiding this comment.
Is this meant to be build.ninja? If so it is already covered by a wildcard
There was a problem hiding this comment.
This is probably coming from the "sed -ie” commands in the script where “e” is taken as the name for the temp file.
|
@amraboelela Could you rebase this onto master just to eliminate the merge commits please. |
|
Would also help to squash the commits and improve the commit messages for future readability. |
|
Created new PR #1249 Closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.