NSNumber: More Darwin compatibility fixes #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When comparing signed/unsigned integers, always compare both as SInt128. - Add special handling for comparing values with Float.nan and Double.nan.
|
@ianpartridge If you want to commit #1204 first, I can always rebase this on top and fix up those test cases you commented out. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
I confirm this fixes the NSNumber issues that my extra tests in #1204 exposed. I think it would be best to merge this one first, then my PR? |
ianpartridge
approved these changes
Sep 13, 2017
|
Ah yes, I forgot you tested #1204 on top of this |
|
CC: @norio-nomura |
phausler
approved these changes
Sep 14, 2017
|
@swift-ci please test and merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing signed/unsigned integers, always compare both
as SInt128.
Add special handling for comparing values with Float.nan and
Double.nan.