Thread safety for URLSession #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnno1962
force-pushed
the
thread-safety
branch
from
9993672 to
35a309e
Compare
|
@swift-ci please test |
weissi
reviewed
Sep 11, 2017
| @@ -192,6 +192,7 @@ public let NSURLSessionTransferSizeUnknown: Int64 = -1 | |||
| open class URLSession : NSObject { | |||
| fileprivate let _configuration: _Configuration | |||
| fileprivate let multiHandle: _MultiHandle | |||
| fileprivate let taskIdentifierLock = NSLock() | |||
There was a problem hiding this comment.
I’ve switched to using the workQueue for consistency
weissi
reviewed
Sep 11, 2017
| @@ -192,6 +192,7 @@ public let NSURLSessionTransferSizeUnknown: Int64 = -1 | |||
| open class URLSession : NSObject { | |||
| fileprivate let _configuration: _Configuration | |||
| fileprivate let multiHandle: _MultiHandle | |||
| fileprivate let taskIdentifierLock = NSLock() | |||
There was a problem hiding this comment.
also: the sessionDescription and delegate properties are also mutable and accessible from the outside. I suppose the should be locked too.
|
@swift-ci please test |
pushkarnk
approved these changes
Sep 14, 2017
|
@swift-ci please test and merge |
|
cc @saiHemak |
|
Thanks @pushkarnk, Are we any closer to merging #1198? Is there anything more I can do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Apple,
I’ve been seeing assertion failures using a URLSession from multiple threads on this line. This PR makes a small change so allocation of the taskIdentifier in URLSession is thread safe.
Thanks.