[4.0] SR-5640: JSONEncoder misrepresents UInt.max #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
I think we're still waiting on an official tag for swift-4.0 before we continue to make fixes on this branch. |
|
Reopening to get this into the 4.0 branch. |
|
@swift-ci please test |
This is a workaround rather than a full fix. - NSNumber(value: UInt.max).stringValue was returning "-1" instead of "18446744073709551615" because NSNumber holds any value > Int64.max as a 128Bit quantity using a high Int and low UInt. It marks this type as an 'SInt128Type'. - CFNumberFormatterCreateStringWithNumber() uses CFNumberGetType() to get this type however CoreFoundation wants to hide SInt128Type (probably for backwards compatibilty) and instead returns it as an SInt64Type. Thus only the low part of the NSNumber is used for the number and this is interpreted as an Int64. - The workaround is simply in NSNumber.description(withLocale:) to test to see if the value is of type SInt128Type and if so use String(format: "%@") to convert it to a string instead of using CFNumberFormatterCreateStringWithNumber(). This should be ok for most situations since it is only used for positive integers and there are no issues with formatting leading zeros or decimal points. - For JSONWriter._serializationString(for: NSNumber) the value is tested to see if it is not a floating point value and if so the .stringValue method is used to create a string. - NSNumber.description(withLocale:) - cache the CFNumberFormatter when locale is nil as a small speedup.
ianpartridge
force-pushed
the
jsonencoder-uintmax-4.0
branch
from
ea09499 to
feb2950
Compare
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1173 to
swift-4.0-branch.