-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable URLSesssion tests #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable URLSesssion tests #1042
Conversation
@swift-ci please test |
|
I'm looking into the failure. Doesn't look straightforward. |
Created #1049 for the failure |
f749d6f
to
2522233
Compare
@swift-ci please test |
1 similar comment
@swift-ci please test |
One of those intermittent failures. The completion handler was called with a non-nil |
I'm running the test one more time. @swift-ci please test |
There are two types of URLSession tests - ones that use the completion handler and others that use delegates. With the tests that use delegates disabled, we seem to be doing good. However, after enabling those, the completion handler tests seem to be intermittently failing. In a debugging session today I realised that there can be some inter-test dependencies because though we are creating a new server for each test, we aren't making sure the previous server has completed and shutdown. There is a need to comprehend things better here. |
Enabling the remaining URLSession tests. These had been disabled following some CI failures that we couldn't reproduce locally. Late last month we enabled the tests with completion handlers with some extra diagnostic messages. It looks like the CI has been stable for a while (fingers crossed!). This PR enables the remaining tests that use delegates.