Skip to content

Make totalDownloaded to be specific to HTTPURLProtocol #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2017
Merged

Make totalDownloaded to be specific to HTTPURLProtocol #1029

merged 1 commit into from
Jun 14, 2017

Conversation

nethraravindran
Copy link
Contributor

No description provided.

@nethraravindran nethraravindran mentioned this pull request Jun 6, 2017
Merged
@alblue
Copy link
Contributor

alblue commented Jun 6, 2017

Why should this be specific to an HTTPURLDownloadTask? Other URL download types could potentially have a total download as well.

@pushkarnk
Copy link
Member

@swift-ci please test

@nethraravindran
Copy link
Contributor Author

@alblue totalDownloaded is being used to track the progress of HTTP downloads. Other protocols may use their own mechanism to track downloads. Hence it makes more sense to make totalDownloaded specific to HTTPURLProtocol for now.

@pushkarnk
Copy link
Member

Looks good to me, for now. I also agree that, in future, we are going to have some common attributes between the different protocols and we have to figure out the best way to factor them out so that there is no redundancies - whether URLSessionTask is the best place to hold these attributes or we need a generic protocol class is something we'd need to look into.

@pushkarnk
Copy link
Member

@swift-ci please test and merge

1 similar comment
@pushkarnk
Copy link
Member

@swift-ci please test and merge

@swift-ci swift-ci merged commit ecd67b3 into swiftlang:master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nethraravindran @alblue @pushkarnk @swift-ci