S3 bucket name must be updated before deploying #97
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@eneko why close? its a good tip |
|
@tomerd thanks, will re-open |
| Note: This script assumes you have AWS CLI installed and credentials setup in `~/.aws/credentials`. | ||
| Notes: | ||
| - This script assumes you have AWS CLI installed and credentials setup in `~/.aws/credentials`. | ||
| - Update `s3_bucket=swift-lambda-test` in `deploy.sh` before running (AWS S3 buckets require a unique global name) |
There was a problem hiding this comment.
this is helpful. we may want to point out both the bucket and function names in the deploy script
There was a problem hiding this comment.
In my opinion the S3 bucket selection should be in the script, not just in the README.md.
The issue is that the S3 name must be globally unique so a predefined one works only for the owner of it.
There was a problem hiding this comment.
@Andrea-Scuderi, that is a valid point, but I think outside of the scope of this PR.
I think there are two topics to cover:
-
Help new users, unfamiliar with Lambda, get started quickly with these examples. This was the goal for this PR. Maybe documentation within the script would be helpful too.
-
Make deployment script(s) more robust, so it's easy to deploy one or more lambdas within a package with one command. This could be a separate PR, maybe even a separate repo (would be nice to have swift cli tool included to do this).
Focusing on the first point, I'll update the PR to indicate how to update both bucket and lambda function name before deploying.
There was a problem hiding this comment.
would be good to track any future ideas as illustrated ^^ in GitHub issues so we dont loose track of them
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
./scripts/deploy.shfor example functions