Skip to content

hide testing harness in release builds #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Apr 24, 2020

motivation: testing harness should only be used for testing, and uses @testable import which doe not work in release builds

changes: hide code behind #if check

motivation: testing harness should only be used for testing, and uses @testable import which doe not work in release builds

changes: hide code behind #if check
@tomerd tomerd requested a review from fabianfett April 24, 2020 02:36
@tomerd
Copy link
Contributor Author

tomerd commented Apr 24, 2020

I am not 100% sure this is the best way to do this, but tested on both Xcode and macOS/Linux SwiftPM debug/release and seems to work

@tomerd
Copy link
Contributor Author

tomerd commented Apr 24, 2020

cc @aciidb0mb3r to confirm if there is some better way

@tomerd tomerd merged commit bfad186 into master Apr 27, 2020
@fabianfett fabianfett deleted the fix/testing-harness branch April 28, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants