Make Lambda.env() -> String? public #61
Conversation
fabianfett
force-pushed
the
public-env-variables
branch
from
3aa94bb to
6c793c4
Compare
| @@ -44,6 +44,14 @@ public enum Lambda { | |||
| self.run(factory: factory) | |||
| } | |||
|
|
|||
| /// Utility to access/read environment variables | |||
| public static func env(_ name: String) -> String? { | |||
There was a problem hiding this comment.
should we nest this under something like Lambda.Utils? not sure...
There was a problem hiding this comment.
IMHO this would make the code just more verbose. I was even unsure if we should put it under Lambda, since it is namespaced by the package in case someone needs it anyways.
There was a problem hiding this comment.
I would not really mind it as such Lambda.env; not having to import Foundation is a nice goal here.
I'd probably document semantics some more but sounds fine.
I'd -1 ....Utils since are magnets for tons of random stuff, at least on Lambda itself one would think twice before adding 10 more random functions 😉
There was a problem hiding this comment.
I would suggest having Lambda.Environment or container of some sort (e.g., env['foo']). Is Lambda.Context a suitable "home" for it?
Otherwise I don't really mind Lambda.env either.
There was a problem hiding this comment.
Is Lambda.Context a suitable "home" for it?
Sadly our current Lambda.Context is not available at Lambda initialization, where it is most likely that we need environment variables.
There was a problem hiding this comment.
right, I was thinking to introduce an InitializationContext which will have this + the eventLoop and potential can grow down the line. I think it will make for a more extensible API anyways?
There was a problem hiding this comment.
That’s right. I’m +1 on the ‘InitializationContext’... But we must be aware that if we expose the env only there, in the simple Lambda.run(closure) use case developers have no way to access the env variable.
There was a problem hiding this comment.
Since end variables are IMO used for “global effects” might as well make it globally and easily available — so on the Lambda type statically.
// edit: not really “terrible” global effects, just global effects; config stuff etc; I think it’s useful to have those easy to use when needed.
There was a problem hiding this comment.
okay you folks convinced me. @fabianfett would you like to rebase and merge?
Noble goal 👍 |
fabianfett
force-pushed
the
public-env-variables
branch
from
7279bf3 to
5becf01
Compare
Motivation
Developers need to access environment variables quite often at Lambda startup. We want to save them from importing Foundation. 🙃
Changes
This PR makes our internal access env func public.