Improve testing utils #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
feature/testing-harness-sync
branch
from
ed689e1 to
a731c23
Compare
fabianfett
force-pushed
the
feature/testing-harness-sync
branch
2 times, most recently
from
6999f24 to
ea667ec
Compare
tomerd
reviewed
Apr 22, 2020
| handler.handle(context: context, payload: payload) | ||
| }.wait() | ||
|
|
||
| try eventLoopGroup.syncShutdownGracefully() |
There was a problem hiding this comment.
If we use defer we have to do something with the try... that's why i moved it here. Neither wanted to try! nor try?
There was a problem hiding this comment.
@tomerd What do you think?
There was a problem hiding this comment.
I think try! in the defer is fine, or you can try/catch in the defer and print something too
tomerd
reviewed
Apr 22, 2020
| @@ -75,19 +64,32 @@ class LambdaTestingTests: XCTestCase { | |||
| typealias Out = Response | |||
|
|
|||
| func handle(context: Lambda.Context, payload: In, callback: @escaping (Result<Out, Error>) -> Void) { | |||
| XCTAssertFalse(context.eventLoop.inEventLoop) | |||
tomerd
reviewed
Apr 22, 2020
| typealias Out = String | ||
|
|
||
| func handle(context: Lambda.Context, payload: String) -> EventLoopFuture<String> { | ||
| XCTAssertTrue(context.eventLoop.inEventLoop) |
tomerd
reviewed
Apr 22, 2020
| public var requestId: String | ||
| public var traceId: String | ||
| public var invokedFunctionArn: String | ||
| public var timeout: Double |
tomerd
requested changes
Apr 22, 2020
tomerd
reviewed
Apr 22, 2020
tomerd
reviewed
Apr 22, 2020
| } | ||
| eventLoop: eventLoop) | ||
|
|
||
| let result = try eventLoop.flatSubmit { |
tomerd
reviewed
Apr 22, 2020
tomerd
reviewed
Apr 22, 2020
fabianfett
commented
Apr 22, 2020
|
|
||
| public static func test<In, Out, Handler: EventLoopLambdaHandler>( | ||
| _ handler: Handler, | ||
| config: TestConfig = .init(), |
There was a problem hiding this comment.
Urgh. I have overseen this buddy.
motivation: make testing lambda easy changes: * add a AWSLambdaTesting module * add helper methods for testing different types of Lambda handlers / closures
fabianfett
force-pushed
the
feature/testing-harness-sync
branch
from
74819b7 to
4c85713
Compare
tomerd
reviewed
Apr 23, 2020
tomerd
reviewed
Apr 23, 2020
tomerd
reviewed
Apr 23, 2020
Co-Authored-By: tomer doron <tomerd@apple.com>
Co-Authored-By: tomer doron <tomerd@apple.com>
Co-Authored-By: tomer doron <tomerd@apple.com>
tomerd
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.