Skip to content

Capitalized HttpClient to HTTPClient filename #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

Capitalized HttpClient to HTTPClient filename #47

merged 1 commit into from
Mar 25, 2020

Conversation

fabianfett
Copy link
Member

Motivation

  • Filename should match main class.

Changes

  • capitalized filename HttpClient.swift to HTTPClient.swift

@fabianfett fabianfett requested a review from tomerd March 25, 2020 09:33
weissi
weissi suggested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m pretty sure just changing the case of a file breaks stuff in git. I can’t remember 100% but we had an issue with that once, needs investigation. You could rename it to HTTP1Client that’s the hack we did in NIO some years ago

@tomerd
Copy link
Contributor

tomerd commented Mar 25, 2020

I’m pretty sure just changing the case of a file breaks stuff in git. I can’t remember 100% but we had an issue with that once, needs investigation. You could rename it to HTTP1Client that’s the hack we did in NIO some years ago

what I saw in the past with this kind of change is that it confuses git on case-insensitive file systems. since there are still a very small set of contributors we can probably just merge this and re-clone if our local git / fs gets confused

@tomerd tomerd merged commit 87121ec into master Mar 25, 2020
@fabianfett fabianfett deleted the capitalized-httpclient branch March 25, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @tomerd @weissi