Skip to content

add HelloJSON example + README #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Nov 13, 2024

Add a simple JSON input/output example + reference it in the main readme.
I also restructured the main readme to follow the structure that was in V1

I commented out LambdaRuntime+Localserver.swift as it is unused at the moment and causes the CI to fail

@sebsto sebsto requested a review from 0xTim November 13, 2024 11:00
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added some slight tweaks to some of the English because it's a weird language

out.txt && cat out.txt && rm out.txt
```

Note that the payload is expected to be a valid JSON string.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is encoded right?

Suggested change
Note that the payload is expected to be a valid JSON string.
Note that the payload is expected to be a valid encoded JSON string.

sebsto and others added 7 commits November 13, 2024 13:50
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
@sebsto sebsto merged commit c22f527 into swift-server:main Nov 13, 2024
@sebsto sebsto deleted the sebsto/hellojson branch November 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants