Don’t create an EventLoopFuture chain #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-dont-leak-eventloopfutures
branch
2 times, most recently
from
c0839ef to
f24a9ce
Compare
|
Verified with instruments that memory is not increasing anymore. |
|
If we add an |
fabianfett
force-pushed
the
ff-dont-leak-eventloopfutures
branch
from
f24a9ce to
0bd5415
Compare
tomerd
reviewed
Mar 5, 2020
tomerd
reviewed
Mar 5, 2020
tomerd
reviewed
Mar 5, 2020
tomerd
reviewed
Mar 5, 2020
tomerd
approved these changes
Mar 5, 2020
fabianfett
force-pushed
the
ff-dont-leak-eventloopfutures
branch
from
0bd5415 to
8b03533
Compare
fabianfett
force-pushed
the
ff-dont-leak-eventloopfutures
branch
from
8b03533 to
70e1647
Compare
tomerd
reviewed
Mar 6, 2020
| @@ -89,7 +89,7 @@ class LambdaTest: XCTestCase { | |||
| } | |||
| let result = try future.wait() | |||
| XCTAssertGreaterThan(result, 0, "should have stopped before any request made") | |||
| XCTAssertLessThan(result, maxTimes, "should have stopped before \(maxTimes)") | |||
| XCTAssertLessThanOrEqual(result, maxTimes, "should have stopped at \(maxTimes)") | |||
There was a problem hiding this comment.
better to change maxTimes to some larger number (1000) instead otherwise we loose the test value
There was a problem hiding this comment.
thanks for the fix, the XCTAssertLessThan should stay so we are testing we stopped before reaching maxTimes
There was a problem hiding this comment.
Oh. Sure that makes tons of sense.
fabianfett
force-pushed
the
ff-dont-leak-eventloopfutures
branch
2 times, most recently
from
3fa503f to
33c7288
Compare
fabianfett
force-pushed
the
ff-dont-leak-eventloopfutures
branch
from
33c7288 to
8da62ce
Compare
tomerd
pushed a commit
that referenced
this pull request
Mar 6, 2020
motivation: prevent memory bloat changes: * recurse instead of event loop chain * fix flaky test
tomerd
pushed a commit
that referenced
this pull request
Mar 7, 2020
motivation: prevent memory bloat changes: * recurse instead of event loop chain * fix flaky test
tomerd
pushed a commit
that referenced
this pull request
Mar 7, 2020
motivation: prevent memory bloat changes: * recurse instead of event loop chain * fix flaky test
tomerd
pushed a commit
that referenced
this pull request
Mar 7, 2020
motivation: prevent memory bloat changes: * recurse instead of event loop chain * fix flaky test
tomerd
pushed a commit
that referenced
this pull request
Mar 7, 2020
motivation: prevent memory bloat changes: * recurse instead of event loop chain * fix flaky test
tomerd
pushed a commit
that referenced
this pull request
Mar 7, 2020
motivation: prevent memory bloat changes: * recurse instead of event loop chain * fix flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we build up an EventLoopFuture chain. This pr fixes this. Its performance (speed) though is a little slower than before. But I think not running into memory limits at this point outweighs the performance considerations.