Skip to content

refactor tests #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2020
Merged

refactor tests #23

merged 2 commits into from
Mar 9, 2020

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Mar 9, 2020

motivation: get test suite in better shape for core API changes

changes:

  • test lambda behavior instead of sevrer error handling in string/codable test suites
  • add more basic behavior tests to core tesr suite
  • refacotr common parts to make tests DRYer
  • remove custom result types (pre swift 5 lefovers)

@tomerd tomerd requested a review from fabianfett March 9, 2020 00:15
@tomerd tomerd force-pushed the refactor-tests branch 2 times, most recently from 4d3370c to 0a99949 Compare March 9, 2020 02:16
@tomerd tomerd mentioned this pull request Mar 9, 2020
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomerd added 2 commits March 9, 2020 09:58
motivation: get test suite in better shape for core API changes

changes:
* test lambda behavior instead of sevrer error handling in string/codable test suites
* add more basic behavior tests to core tesr suite
* refacotr common parts to make tests DRYer
* remove custom result types (pre swift 5 lefovers)
@tomerd tomerd merged commit a6af55c into master Mar 9, 2020
@tomerd tomerd deleted the refactor-tests branch March 10, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants