refactor #13
Merged
refactor #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Mar 6, 2020
fabianfett
reviewed
Mar 6, 2020
tomerd
added a commit
that referenced
this pull request
Mar 7, 2020
motivation: make lambda execution sequence easier to reason about changes: * add `peekFailure` extension to `EventLoopFuture` to handle error without side effects * update process chain to make use of `peekFailure`
tomerd
added a commit
that referenced
this pull request
Mar 7, 2020
motivation: make lambda execution sequence easier to reason about changes: * add `peekFailure` extension to `EventLoopFuture` to handle error without side effects * update process chain to make use of `peekFailure`
tomerd
added a commit
that referenced
this pull request
Mar 7, 2020
motivation: make lambda execution sequence easier to reason about changes: * add `peekFailure` extension to `EventLoopFuture` to handle error without side effects * update process chain to make use of `peekFailure`
tomerd
added a commit
that referenced
this pull request
Mar 7, 2020
motivation: make lambda execution sequence easier to reason about changes: * add `peekFailure` extension to `EventLoopFuture` to handle error without side effects * update process chain to make use of `peekFailure`
tomerd
added a commit
that referenced
this pull request
Mar 7, 2020
motivation: make lambda execution sequence easier to reason about changes: * add `peekFailure` extension to `EventLoopFuture` to handle error without side effects * update process chain to make use of `peekFailure`
tomerd
force-pushed
the
refactor
branch
2 times, most recently
from
95383be to
8fe2986
Compare
tomerd
commented
Mar 7, 2020
fabianfett
reviewed
Mar 7, 2020
Closed
Lukasa
reviewed
Mar 7, 2020
|
@fabianfett I think this is ready for final review/merge |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: safer concurrency, better tests
changes: