-
Notifications
You must be signed in to change notification settings - Fork 113
add initialization context #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
b89f220
39f2241
93bc100
28be2ee
fe320d2
38d7088
f21f4a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,33 @@ import Dispatch | |
import Logging | ||
import NIO | ||
|
||
// MARK: - InitializationContext | ||
|
||
extension Lambda { | ||
/// Lambda runtime initialization context. | ||
/// The Lambda runtime generates and passes the `InitializationContext` to the Lambda handler as an argument. | ||
public final class InitializationContext { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also considered |
||
/// `Logger` to log with | ||
/// | ||
/// - note: The `LogLevel` can be configured using the `LOG_LEVEL` environment variable. | ||
public let logger: Logger | ||
|
||
/// The `EventLoop` the Lambda is executed on. Use this to schedule work with. | ||
/// This is useful when implementing the `EventLoopLambdaHandler` protocol. | ||
/// | ||
/// - note: The `EventLoop` is shared with the Lambda runtime engine and should be handled with extra care. | ||
/// Most importantly the `EventLoop` must never be blocked. | ||
public let eventLoop: EventLoop | ||
tomerd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
internal init(logger: Logger, eventLoop: EventLoop) { | ||
self.eventLoop = eventLoop | ||
self.logger = logger | ||
} | ||
} | ||
} | ||
|
||
// MARK: - Context | ||
|
||
extension Lambda { | ||
/// Lambda runtime context. | ||
/// The Lambda runtime generates and passes the `Context` to the Lambda handler as an argument. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,8 @@ extension Lambda { | |
logger.debug("initializing lambda") | ||
// 1. create the handler from the factory | ||
// 2. report initialization error if one occured | ||
return factory(self.eventLoop).hop(to: self.eventLoop).peekError { error in | ||
let context = InitializationContext(logger: logger, eventLoop: self.eventLoop) | ||
return factory(context).hop(to: self.eventLoop).peekError { error in | ||
self.runtimeClient.reportInitializationError(logger: logger, error: error).peekError { reportingError in | ||
// We're going to bail out because the init failed, so there's not a lot we can do other than log | ||
// that we couldn't report this error back to the runtime. | ||
|
@@ -57,6 +58,7 @@ extension Lambda { | |
let context = Context(logger: logger, eventLoop: self.eventLoop, invocation: invocation) | ||
logger.debug("sending invocation to lambda handler \(handler)") | ||
return handler.handle(context: context, event: event) | ||
.hop(to: self.eventLoop) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tomerd The only situation in which we would need to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this can happen is if they use some library (lets say a DB client) that manages it's own ELG for whatever reason and they return a future that originated from that ELG. while this is not a pattern we encourage, we also can't stop anyone from doing it so to be safe we should hop imo There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Vapor doesn't do a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just as a reference: Where ever NIO takes a future (not that many APIs outside of bootstraps), it'll |
||
.mapResult { result in | ||
if case .failure(let error) = result { | ||
logger.warning("lambda handler returned an error: \(error)") | ||
|
Uh oh!
There was an error while loading. Please reload this page.