Added jq requirement to examples readme #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
attempts to address #105 |
tomerd
approved these changes
Jun 2, 2020
|
thanks @waterskier2007 |
tomerd
reviewed
Jun 2, 2020
Examples/LambdaFunctions/README.md
Outdated
| @@ -19,6 +19,8 @@ Steps to deploy this sample to AWS Lambda using the AWS CLI: | |||
| ``` | |||
|
|
|||
| Note: This script assumes you have AWS CLI installed and credentials setup in `~/.aws/credentials`. | |||
|
|
|||
| Note: You must also have the [jq](https://stedolan.github.io/jq/download/) command line tool installed. | |||
There was a problem hiding this comment.
I think this is also required by the SAM example below, so maybe move this ~L6?
tomerd
requested changes
Jun 2, 2020
|
confused by the line recommended in the comment. Are you suggesting to relocate to L6? |
|
hi @waterskier2007, yea add it before the sections for CLI and SAM since its required by both |
|
@tomerd hopefully this resolves the issue |
|
@swift-server-bot test this please |
fabianfett
approved these changes
Jun 3, 2020
tomerd
reviewed
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.